Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spot light range cutoff when using shadows #1313

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix spot light range cutoff when using shadows #1313

merged 1 commit into from
Sep 17, 2024

Conversation

tomas7770
Copy link
Contributor

@tomas7770 tomas7770 commented Sep 14, 2024 •
edited
Loading

Description

Fixes spot lights being "cut" before the maximum range is reached, when shadows are used on a spot light with global scale lower than 1.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.
  • Add entry to the changelog's unreleased section.

@tomas7770 tomas7770 linked an issue Sep 14, 2024 that may be closed by this pull request
Spot shadows cause light range cutoff #1312
Closed
@github-actions GitHub Actions
Copy link
Contributor

PR Preview Action v1.4.7
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1313/
on branch gh-pages at 2024-09-14 21:12 UTC

@codecov Codecov
Copy link

codecov bot commented Sep 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 35.89%. Comparing base (eb8671a) to head (1536ca6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
engine/src/render/deferred_shading/plugin.cpp 0.00% 3 Missing ⚠️
...gine/src/render/shadow_atlas_rasterizer/plugin.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1313      +/-   ##
==========================================
- Coverage   35.90%   35.89%   -0.01%     
==========================================
  Files         399      399              
  Lines       31917    31920       +3     
==========================================
- Hits        11459    11458       -1     
- Misses      20458    20462       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomas7770 tomas7770 marked this pull request as ready for review September 14, 2024 21:35
@tomas7770 tomas7770 requested review from RiscadoA and a team as code owners September 14, 2024 21:35
RiscadoA
RiscadoA approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM!

@tomas7770 tomas7770 force-pushed the 1312-spot-shadows-cause-light-range-cutoff branch from 82ada11 to 251653b Compare September 16, 2024 10:23
@tomas7770 tomas7770 enabled auto-merge (rebase) September 17, 2024 18:00
@tomas7770 tomas7770 force-pushed the 1312-spot-shadows-cause-light-range-cutoff branch from 251653b to 1536ca6 Compare September 17, 2024 18:01
@tomas7770 tomas7770 merged commit cd0d02f into main Sep 17, 2024
9 checks passed
@tomas7770 tomas7770 deleted the 1312-spot-shadows-cause-light-range-cutoff branch September 17, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaomanita joaomanita joaomanita approved these changes

@Dacops Dacops Dacops approved these changes

@RiscadoA RiscadoA RiscadoA approved these changes

Assignees
No one assigned
Labels
A-Engine B-Rendering C-Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spot shadows cause light range cutoff
4 participants
@tomas7770 @RiscadoA @Dacops @joaomanita